I have a mix of old rust coverd traps and some with light rise and shiny steel. How long should it take to soak and what results should I expect from the traps that still have shiny steel. The rust seem to take quickly but shiny steel remains with no color.

An I right to assume the die wont take wher ther is no rust?

My guess is the shiny steel will have to hang in the weather for while before it takes on much patina.

That's what I was thinking but is been over 15 or 16 years since I died traps. Had a few rusted old ones but bought a new ones last season to teach the boys. I just degreesed them and set them last year

Guess I should have left them outside in the weather tell they were completely coated with urs instead of storing them in the shed right after season.

If you boil the shiny ones, they will then start to rust really quickly. But, I usually just boil new ones to clean them and wax. They work fine that way.

I Dishwasher all new traps. Dip in Vinegar a few minutes. Rinse in clean water and leave outside for a thin coat of rust.

After they come to a boil , turn off the heat let cool and reheat.
It's the old way and in my opinion the best way to dye traps
And the old wax can be lifted right off the top when it's cool

I told this to my dishwasher and she told me to wash them myself.

That is what I did for the majority of my trapping career.